Use PHPUnit 12 where possible #7974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHPStan issues unrelated: #7975 |
b074e2d to
5b6efcb
Compare
5b6efcb to
220adc7
Compare
| #[\PHPUnit\Framework\Attributes\DataProvider('provideMultipleTags')] | ||
| public function testExtractAll($html, array $counts): void | ||
| public function testExtractAll(string $html, array $counts, int $count): void |
There was a problem hiding this comment.
Methods require to match dataProviders return in 12.* version. Same data provider used for different methods.
| */ | ||
| #[\PHPUnit\Framework\Attributes\DataProvider('provideLifecycle')] | ||
| public function testOnFlushOtherUser($changeset): void | ||
| public function testOnFlushOtherUser($changeset, $expectedFields, bool $insert = true): void |
There was a problem hiding this comment.
Methods require to match dataProviders return in 12.* version. Same data provider used for different methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Use PHPUnit 12 where possible. See also: #7880
Why?
Use latest version and get rid of outdated dependencies. Open the version constraint that PHP 8.3 and 8.4 run on PHPUnit 12.