Move AbstractLoader to Admin Bundle #7967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a32313d to
7fd2453
Compare
| @@ -572,6 +573,14 @@ Removed unused arguments: | |||
| - `sulu_page.structure.properties_xml_parser`: `sulu_admin.properties_xml_parser` | |||
| - `sulu_page.structure.schema_xml_parser`: `sulu_admin.schema_xml_parser` | |||
|
|
|||
| ### Moved files for 3.0 | |||
|
|
|||
| - `src/Sulu/Component/Content/Metadata/Loader/schema/form-1.0.xsd` -> `src/Sulu/Bundle/AdminBundle/Resources/config/schema/form-1.0.xsd` | |||
There was a problem hiding this comment.
@wachterjohannes maybe requires changes in the deployment for the schemas
e8fbe1a to
626f035
Compare
626f035 to
7efc1b4
Compare
| @@ -35,7 +35,7 @@ class StructureFormMetadataLoaderTest extends TestCase | |||
| /** | |||
| * @var string | |||
| */ | |||
| public const CACHE_DIR = __DIR__ . '/../../../../../../../tests/Resources/cache'; | |||
| public const CACHE_DIR = __DIR__ . '/../../../../../../../../tests/Resources/cache'; | |||
There was a problem hiding this comment.
this class was moved and the path was not adopted which did end in creating a src/tests directory instead of resources/cache dir.
44b404e to
9746ce4
Compare
| @@ -27,7 +27,7 @@ class XmlFormMetadataLoaderTest extends TestCase | |||
| { | |||
| use ProphecyTrait; | |||
|
|
|||
| public const CACHE_DIR = __DIR__ . '/../../../../../../../tests/Resources/cache'; | |||
| public const CACHE_DIR = __DIR__ . '/../../../../../../../../tests/Resources/cache'; | |||
There was a problem hiding this comment.
same as above class was previously moved without adjusting the path
Prokyonn
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Move AbstractLoader to Admin Bundle.
Why?
We should make the admin bundle not longer depending on something outside of it, one step forward to it.
The AbstractLoader is only used by the Form Loader (already inside Admin Bundle) and the Structure Loader (part of component class should be removed before 3.0 release).