Skip to content

Fix IcomoonProvider warning #7965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

martinlagler
Copy link
Contributor

@martinlagler martinlagler commented May 19, 2025

Q A
Bug fix? no
New feature? no
BC breaks? no
Related Issues #8021
Deprecations? no
License MIT

What's in this PR?

Fix Undefined array key warning

Copy link
Member

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typehint is wrong

@@ -50,7 +50,7 @@ public function getIcons(string $path): array
*/
foreach ($icon->icon->paths as $index => $path) {
/** @var \stdClass $attrs */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** @var \stdClass $attrs */
/** @var \stdClass|null $attrs */

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label May 26, 2025
@martinlagler martinlagler force-pushed the bugfix/fix-iconprovider-warnings branch from 3f97b2a to 4265558 Compare May 26, 2025 06:55
@alexander-schranz alexander-schranz merged commit 9f203af into sulu:2.6 May 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants