Skip to content

Use snapshots for security and media metadata tests #7963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexander-schranz
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #7943
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Use snapshots for security metadata tests.

Why?

This helps us to find regression in #7943.

@alexander-schranz alexander-schranz added the Technical Debt Impacts code quality, no or just small impact on end developers and users label May 16, 2025
@alexander-schranz alexander-schranz marked this pull request as ready for review May 16, 2025 10:57
@alexander-schranz
Copy link
Member Author

alexander-schranz commented May 16, 2025

@Prokyonn FYI

PS: we should add a metadata tests based on snapshots for any bundle which defines there own forms xml files.

@alexander-schranz alexander-schranz force-pushed the enhancement/security-metadata-tests branch from ed618dc to 95f9a49 Compare May 16, 2025 11:08
@alexander-schranz alexander-schranz force-pushed the enhancement/security-metadata-tests branch from 51d3fc7 to 41abd05 Compare May 16, 2025 11:21
@alexander-schranz alexander-schranz changed the title Use snapshots for security metadata tests Use snapshots for security and media metadata tests May 16, 2025
@alexander-schranz
Copy link
Member Author

@Prokyonn updated also the media bundle metadata test to snapshot.

@alexander-schranz alexander-schranz force-pushed the enhancement/security-metadata-tests branch from 41abd05 to decad5c Compare May 16, 2025 11:29
@alexander-schranz alexander-schranz enabled auto-merge (squash) May 16, 2025 11:30
@alexander-schranz alexander-schranz merged commit 6dd0d76 into sulu:3.0 May 16, 2025
9 checks passed
@alexander-schranz alexander-schranz deleted the enhancement/security-metadata-tests branch May 16, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants