Rename PropertiesXmlParser to DeprecatedPropertiesXmlParser #7939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdf2525 to
95b082f
Compare
95b082f to
780ef13
Compare
Comment on lines
+19
to
+26
| /** | ||
| * @template T of mixed | ||
| * | ||
| * @param T $default | ||
| * | ||
| * @return T|bool|int|string|null | ||
| */ | ||
| private function getValueFromXPath(string $path, \DOMXPath $xpath, ?\DOMNode $context = null, $default = null) |
There was a problem hiding this comment.
improved the PHP Typing here the trait is already internal so needs not documentation in upgrade
| @@ -31,7 +31,7 @@ class FormXmlLoader extends AbstractLoader | |||
| public const SCHEMA_NAMESPACE_URI = 'http://schemas.sulu.io/template/template'; | |||
|
|
|||
| public function __construct( | |||
| private PropertiesXmlParser $propertiesXmlParser, | |||
| private DeprecatedPropertiesXmlParser $propertiesXmlParser, | |||
There was a problem hiding this comment.
here we will do a rewrite of DeprecatedPropertiesXmlParser to PropertiesXmlParser which will directly return new metadata instead of the old one.
| @@ -74,7 +74,7 @@ class StructureXmlLoader extends AbstractLoader | |||
| */ | |||
| public function __construct( | |||
| private CacheLifetimeResolverInterface $cacheLifetimeResolver, | |||
| private PropertiesXmlParser $propertiesXmlParser, | |||
| private DeprecatedPropertiesXmlParser $propertiesXmlParser, | |||
There was a problem hiding this comment.
the whole service will later be removed after Form and Template loader are implemented.
|
@Prokyonn FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Rename PropertiesXmlParser to DeprecatedPropertiesXmlParser.
Why?
This let me implement a new
PropertiesXmlParserwhich is used forFormXmlLoaderwithout have to refactor also theStructureXmlLoader.