Move FormXmlLoader to new metadata namespace #7937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ | |||
| * with this source code in the file LICENSE. | |||
| */ | |||
|
|
|||
| namespace Sulu\Bundle\AdminBundle\Tests\Unit\FormMetadata\Validation; | |||
| namespace Sulu\Bundle\AdminBundle\Tests\Unit\Metadata\FormMetadata\Validation; | |||
There was a problem hiding this comment.
the classes where already in the new namespace just the tests where in the old one
fae7798 to
ce39b1f
Compare
|
@Prokyonn FYI |
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| namespace Sulu\Content\Infrastructure\Symfony\HttpKernel\Compiler; | |||
|
|
|||
| use Sulu\Bundle\AdminBundle\FormMetadata\FormXmlLoader; | |||
| use Sulu\Bundle\AdminBundle\Metadata\FormMetadata\Loader\FormXmlLoader; | |||
There was a problem hiding this comment.
moved to the new metadata namespace as the old one should get removed soonish
Prokyonn
approved these changes
May 2, 2025
ce39b1f to
d2d06c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Move FormXmlLoader to new metadata namespace.
This moves:
Sulu\Bundle\AdminBundle\Metadata\FormMetadata\Loader\FormXmlLoadertoSulu\Bundle\AdminBundle\FormMetadata\FormXmlLoaderThis class is already marked as internal since 3.0.
Some tests of classes which are already in that namespace where also moved to the correct location.
Why?
The old namespace will with the old metadata be removed.