Replace old metadata usage in new content bundle #7931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74ebe3d to
fb13d5b
Compare
a01acfc to
270e4f8
Compare
| $value = $property->isLocalized() ? $defaultLocalizedData[$name] ?? null : $defaultLocalizedData[$name] ?? null; | ||
| $isMultilingual = $property->isMultilingual(); | ||
|
|
||
| $value = $isMultilingual ? $defaultLocalizedData[$name] ?? null : $defaultLocalizedData[$name] ?? null; |
There was a problem hiding this comment.
Reminder for us check multilingual="false" handling. /cc @Prokyonn
808ca19 to
130e4bf
Compare
46ba1a4 to
0f3b642
Compare
5c5fd75 to
80f51ea
Compare
80f51ea to
962b885
Compare
There was a problem hiding this comment.
removed as article, page, snippet already did not use it only example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Replace old metadata usage in new content bundle.
There are a few more todo but in upcoming PRs.
Why?
Get rid of old metadata.