Make new metadata locale independent to contain all data #7930
Conversation
1c4c1f5 to
cde1651
Compare
ee095b8 to
d7d3de2
Compare
9dba93f to
8a5d751
Compare
| "disabledCondition": null, | ||
| "visibleCondition": null, | ||
| "description": "", |
There was a problem hiding this comment.
small change here empty descriptions, title, label. infotests, placeholders ... are not longer returned.
| @@ -1,12 +1,9 @@ | |||
| { | |||
| "name": "default", | |||
| "title": "Animals", | |||
| "form": { | |||
There was a problem hiding this comment.
we can not set the position of a property added via subscriber this are just moved down
8a5d751 to
da7e2e8
Compare
| */ | ||
| public function setTitles(array $titles) | ||
| { | ||
| $this->titles = $titles; |
There was a problem hiding this comment.
should we check here, that the key is always a string to prevent strange sideeffects later?
There was a problem hiding this comment.
as discussed the callers responsible to validate that it is a array<string, string> in our case mostly the xml parsers work.
|
As we are already touching all of these files, wouldn't it make sense to remove the php doc types and add them as real php types? @alexander-schranz |
|
@Prokyonn agree but would do that parts after the whole refactoring when we know which classes will stay. |
What's in this PR?
Make new metadata not locale aware.
Why?
We want to remove the old metadata classes but to avoid that the metadata is loaded per locale again we need
With the removal of the old metadata classes xml would be parsed per locale to avoid this we change the metadata to keep all admin locales in them.