Remove reference handling of tags in properties parser #7925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2645643 to
bcebbdb
Compare
bcebbdb to
e364867
Compare
| if (isset($this->requiredTagNames[$type])) { | ||
| foreach ($this->requiredTagNames[$type] as $requiredTagName) { | ||
| if (!\array_key_exists($requiredTagName, $tags)) { | ||
| throw new RequiredTagNotFoundException($result['key'], $requiredTagName); |
There was a problem hiding this comment.
We should readd this but not inside the loader.
| @@ -20,7 +20,7 @@ | |||
| use Symfony\Contracts\Translation\TranslatorInterface; | |||
|
|
|||
| /** | |||
| * Parse properties structure from an XML file. | |||
| * @internal this class is not part of the public API and may be changed or removed without further notice | |||
There was a problem hiding this comment.
this should make it in future easier if we need again changes in the parser or loader as we don't longer need to keep bc in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove reference handling of tags in properties parser. And make the services internal.
Why?
The tags reference handling is really changed and valdiation and loading should be seperated, to be open for future changes we should also mark such service as internal as its loading should be in our full control.