Move SchemaXmlParser and PropertiesXmlParser to Admin bundle and make XmlParserTrait internal #7924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed3dcf5 to
29664c7
Compare
mamazu
reviewed
Apr 28, 2025
| @@ -66,6 +66,18 @@ | |||
| </argument> | |||
| </service> | |||
|
|
|||
| <service id="sulu_admin.properties_xml_parser" | |||
| class="Sulu\Bundle\AdminBundle\Metadata\FormMetadata\Parser\PropertiesXmlParser" | |||
| public="false"> | |||
There was a problem hiding this comment.
Isn't public false the default?
… XmlParserTrait internal
29664c7 to
f82001b
Compare
Prokyonn
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Move SchemaXmlParser and PropertiesXmlParser to Admin bundle and make XmlParserTrait internal.
Why?
The old metadata and structure namespaces should get removed and all required parts for the admin bundle should be in the admin bundle itself.