Fix return empty array if teaser selection property resolver data not matching #7922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prokyonn
reviewed
Apr 28, 2025
| @@ -32,7 +32,7 @@ public function resolve(mixed $data, string $locale, array $params = []): Conten | |||
| || !\array_key_exists('items', $data) | |||
| || !\is_array($data['items']) | |||
| ) { | |||
| return ContentView::create($data, $returnedParams); | |||
There was a problem hiding this comment.
Can you also add a small test for this in the TeaserSelectionPropertyResolverTest ?
There was a problem hiding this comment.
@Prokyonn good catch 👍 added
8caa45c to
829ad8f
Compare
Prokyonn
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Return always empty array for teaser selection if unexpected data was given the the property resolver.
Why?
If I switch a block type or change property xmls without a migration a teaser selection should return a empty array instead of the eventually false raw data of another type.
Currently this code snippet can error:
{% for teaser in content.teasers %}as it might return null, string or something else.