Grouping test output by Bundle in Github Actions #7920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a1a27a to
217f67c
Compare
217f67c to
9645fe3
Compare
|
The output should only occur on CI, so we should add an Environment variable and check for it. |
Comment on lines
11
to
12
| env: | ||
| IS_GITHUB_ACTION: 1 |
There was a problem hiding this comment.
would more go with explicit name like CI_GROUP_OUTPUT=1
else we would not require to define an own variable as I think github would always set GITHUB_ACTIONS=true: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables
I'm fine with both changes.
cced545 to
e421ff3
Compare
|
@alexander-schranz Looks weird with the true, but still works. |
alexander-schranz
approved these changes
May 2, 2025
e421ff3 to
dde5379
Compare
| } | ||
| echo "\n"; | ||
|
|
||
| if (false === $input->getOption('no-component-tests') || $input->getOption('all')) { | ||
| write_header('Components'); |
There was a problem hiding this comment.
@mamazu we should put the components also into an own collapsed group, else its a little bit confusing currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Why?
With the amount of output the tests produce you have to scroll a lot when the first components fail. And the search isn't helping 'cause it only sometimes works.
This way you can just expand the section(s) that are broken.