Skip to content

Remove sulu website twig attributes configuration #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Apr 25, 2025

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #7914
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Remove config config/packages/sulu_website.yaml for twig attributes and its usages.

sulu_website:
-    twig:
-        attributes:
-            urls: false
-            path: false

If you have nothing else configured, the whole file can be removed.

Why?

Test bundle does currently not work without website bundle as it configures this. As this config throws and deprecation since 2.3 we can now remove it.

@alexander-schranz alexander-schranz force-pushed the enhancement/sulu-website-configuration branch from d60842b to a1c7763 Compare April 25, 2025 11:06
@alexander-schranz alexander-schranz added the DX Affecting the end developer label Apr 25, 2025
@alexander-schranz alexander-schranz marked this pull request as ready for review April 25, 2025 11:08
@alexander-schranz alexander-schranz force-pushed the enhancement/sulu-website-configuration branch 2 times, most recently from e6c8fd2 to d262f05 Compare April 25, 2025 11:32
@alexander-schranz alexander-schranz force-pushed the enhancement/sulu-website-configuration branch from d262f05 to 14b4b4a Compare April 25, 2025 11:41
@alexander-schranz alexander-schranz added the Technical Debt Impacts code quality, no or just small impact on end developers and users label Apr 25, 2025
@Prokyonn Prokyonn enabled auto-merge (squash) April 25, 2025 16:40
@Prokyonn Prokyonn merged commit 4ec9740 into sulu:3.0 Apr 25, 2025
17 of 18 checks passed
@alexander-schranz alexander-schranz deleted the enhancement/sulu-website-configuration branch April 25, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants