Skip to content

Fix detecting of content-types which are not available #7913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wachterjohannes
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets
Related issues/PRs
License MIT
Documentation PR

What's in this PR?

This fixes the sulu:build command in the skeleton.

Why?

The audience taget group selection breaks the sulu:build if the bundle is not enabled.

@wachterjohannes wachterjohannes force-pushed the fix-validation-of-existing-content-types branch from 23f0a9c to bf1a435 Compare April 24, 2025 12:14
@wachterjohannes wachterjohannes force-pushed the fix-validation-of-existing-content-types branch from bf1a435 to 8d06a8a Compare April 24, 2025 12:16
@wachterjohannes wachterjohannes force-pushed the fix-validation-of-existing-content-types branch from 8d06a8a to 5903baa Compare April 24, 2025 12:22
@alexander-schranz alexander-schranz merged commit da3d9fd into sulu:3.0 Apr 24, 2025
9 of 10 checks passed
@wachterjohannes wachterjohannes deleted the fix-validation-of-existing-content-types branch April 24, 2025 12:35
@alexander-schranz
Copy link
Member

As discussed the Page bundle should not register this. The audience targeting bundle should extend the excerpt if its registered. I probably would go with remove from the xml schema on-invalid. As with the new property resolver we not longer able to detect such things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants