Remove old custom url bundle #7910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc8c476 to
4d45740
Compare
7636b15 to
a618330
Compare
|
The failing test is kind of interesting and missing in the new routing. See https://github.com/sulu/sulu/pull/5561/files for more information. |
39124da to
3667cc7
Compare
|
fixed the routing problem in #7912 |
3667cc7 to
2d549ae
Compare
|
This is ready but would merge after the 3.0.0-alpha2 tag. /cc @wachterjohannes @Prokyonn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove old custom url bundle.
Why?
The PHPCR implementation of the custom url bundle will be replaced with orm solution in #7566
ToDo