Skip to content

Enable new bundles in core Kernel for better validation #7905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexander-schranz
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs prepareation for #7888
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Enable new bundles in core Kernel for better validation.

Why?

See also skeleton changes in sulu/skeleton#276

@alexander-schranz alexander-schranz force-pushed the enhancement/new-bundles-validation branch from bec81af to 0f515c6 Compare April 17, 2025 09:54
@alexander-schranz alexander-schranz force-pushed the enhancement/new-bundles-validation branch from a1e2e86 to cdc444c Compare April 17, 2025 10:23
Comment on lines +40 to +42
"sulu_activity.description.snippets.route_removed": "{userFullName} hat die Route \"{resourceTitle}\" gelöscht.",
"sulu_activity.description.webspaces.default_snippet_modified": "{userFullName} hat das Standardschnipsel für den Bereich \"{context_snippetAreaKey}\" im Webspace \"{resourceTitle}\" geändert",
"sulu_activity.description.webspaces.default_snippet_removed": "{userFullName} hat das Standardschnipsel für den Bereich \"{context_snippetAreaKey}\" im Webspace \"{resourceTitle}\" gelöscht"
Copy link
Member Author

@alexander-schranz alexander-schranz Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prokyonn I'm not sure how we handle crowdin if we remove translations, readded as linting did fail.

@alexander-schranz alexander-schranz added the Technical Debt Impacts code quality, no or just small impact on end developers and users label Apr 17, 2025
@alexander-schranz alexander-schranz force-pushed the enhancement/new-bundles-validation branch from 853dca5 to c115251 Compare April 17, 2025 10:32
@Prokyonn Prokyonn merged commit b13c939 into sulu:3.0 Apr 17, 2025
9 checks passed
Prokyonn pushed a commit to Prokyonn/sulu that referenced this pull request Apr 22, 2025
* Enable new bundles in core Kernel for better validation

* Fix missing translations

* Update baseline
Prokyonn pushed a commit to Prokyonn/sulu that referenced this pull request Apr 22, 2025
* Enable new bundles in core Kernel for better validation

* Fix missing translations

* Update baseline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants