Fix passing null to non-nullable argument in UserManager #7900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
440a1b3 to
1a6a983
Compare
142774b to
46e42f5
Compare
46e42f5 to
b22e9e5
Compare
|
@alexander-schranz I have commited your suggestion |
|
@stollr thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
In the UserManager's
processEmailmethod I have added a check for null-ness of the user's email before it is passed to PHP'sstrcasecmpfunction.Additionally I added two unit test to test the UserManager's save method.
Why?
strcasecmpdoes not accept parameter values of type NULL. Passing NULL to non-nullable parameters of built-in functions was deprecated in PHP 8.1 (see here).