Remove SnippetBundle and Snippet related classes #7888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
258c5a4 to
86c1b06
Compare
e38bc7b to
4fdbb1d
Compare
Comment on lines
+169
to
+173
|
|
||
| return true; | ||
|
|
||
| /* | ||
| // TODO maybe readd validation based on a JSON provided by admin build |
There was a problem hiding this comment.
Via the new pattern I think we are not longer able to validate at any point if a field type really exists, as we always have the fallback to a "default" property resolver which is used for text, text_line, and all other "simple" which not require any resolving mechanic.
4fdbb1d to
fbc0fae
Compare
fbc0fae to
01c1392
Compare
|
@alexander-schranz I think we can merge this one, WDYT? |
|
@Prokyonn awesome 🎉 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove SnippetBundle and Snippet releated classes.
Why?
The old snippet bundle is replaced with the new storage.
To Do
vendor/bin/phpunitbin/runtests -i -aRefactor bundle tests to be independent of the SnippetBundle #7901Baseline adds some new error but all errors of classes which should be removed before the 3.0 release:
s: