Skip to content

Fix usage of ramsey uuid in TagsSubscriber and replace with symfony uuid method #7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Fix usage of ramsey uuid in TagsSubscriber and replace with symfony uuid method #7883

merged 2 commits into from
Apr 9, 2025

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Apr 9, 2025 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Fix usage of ramsey uuid in TagsSubscriber and replace with symfony uuid method for

sulu/src/Sulu/Bundle/HttpCacheBundle/EventSubscriber/TagsSubscriber.php

Lines 79 to 86 in ca9a60f

foreach ($referenceStore->getAll() as $reference) {
$tag = $reference;
if (!Uuid::isValid($reference)) {
$tag = $alias . '-' . $reference;
}
$tags[] = $tag;
}

Why?

For less dependencies we decided to go with symfony ulid packages instead of ramsey uuid. The ramsey uuid is not longer installed since merge of php-task which is also not longer requiring it.

@alexander-schranz alexander-schranz mentioned this pull request Apr 9, 2025
Merged
@alexander-schranz alexander-schranz merged commit 3c25e85 into sulu:3.0 Apr 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexander-schranz