Skip to content

Bugfix for non-int page value #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Bugfix for non-int page value #7881

merged 1 commit into from
Apr 10, 2025

Conversation

martinlagler
Copy link
Contributor

@martinlagler martinlagler commented Apr 9, 2025 •
edited by alexander-schranz
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related issues/PRs sulu/SuluHeadlessBundle#147
License MIT

What's in this PR?

Cast the smart_content page parameter to int before comparing.

Why?

Because otherwise the value is too big for Elasticsearch and an error is thrown...

{"error":{"root_cause":[{"type":"input_coercion_exception","reason":"Numeric value (1.1068046444225731e+20) out of range of int (-2147483648 - 2147483647)\n at [Source: (org.elasticsearch.common.io.stream.ByteBufferStreamInput); line: 1, column: 354]"}],"type":"input_coercion_exception","reason":"Numeric value (1.1068046444225731e+20) out of range of int (-2147483648 - 2147483647)\n at [Source: (org.elasticsearch.common.io.stream.ByteBufferStreamInput); line: 1, column: 354]"},"status":500}

?page=zh1m6

@martinlagler martinlagler mentioned this pull request Apr 9, 2025
Merged
@martinlagler
Copy link
Contributor Author

@alexander-schranz Maybe this should also be changed (https://github.com/sulu/sulu/blob/2.6/src/Sulu/Component/SmartContent/ContentType.php#L335)
as \PHP_INT_MAX is to big and breaks ES.

@martinlagler martinlagler added the Bug Error or unexpected behavior of already existing functionality label Apr 9, 2025
@alexander-schranz alexander-schranz merged commit c30a960 into sulu:2.6 Apr 10, 2025
8 of 9 checks passed
alexander-schranz pushed a commit that referenced this pull request Apr 10, 2025
@martinlagler @alexander-schranz
Bugfix for non-int page value (#7881)
31000c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinlagler @alexander-schranz