Add block visitors for new content storage #7877
Conversation
3c90555 to
32fbd42
Compare
...ng/src/Infrastructure/Sulu/Content/PropertyResolver/BlockVisitor/TargetGroupBlockVisitor.php
Outdated
Show resolved
Hide resolved
8e8f0c0 to
4dec2aa
Compare
4dec2aa to
4a57c85
Compare
4a57c85 to
06587be
Compare
inject blockvisitors to resolver; configure the visitors correctly remove some files Rename HiddenBlockVisitory.php to HiddenBlockVisitor.php move target block visitor rename old target block visitor and adjust service definition rename old block visitors; linter fixes fix TargetGroupBlockVisitorTest add tests linter fixes
6062063 to
b5df70d
Compare
There was a problem hiding this comment.
We just need the new once which are used in the new block property resolver. The old aslong as the PHPCR content types are still there need to stay untouched (or atleast renamed to Deprecated if you have naming conflicts) as they are stilled used by the content types currently. We will remove them in an own PR when removing the content type interface.
| @@ -9,20 +9,23 @@ | |||
| * with this source code in the file LICENSE. | |||
| */ | |||
|
|
|||
| namespace Sulu\Component\Content\Types\Block; | |||
There was a problem hiding this comment.
this should stay based on the old interface as used by the old block content type. So this are 2 seperated services. if you have service name conflicts prefix this old one with sulu_page.deprecated_segement_block_visitor
There was a problem hiding this comment.
i have kept both versions, just that i used Old instead of Deprecated for most of them. I can change that, but else i am not sure if i follow correctly on what the problem is, since old and new visitors are there
There was a problem hiding this comment.
@draconivis looks like they are not longer injected into the block content type correctly because are not longer tagged. add the tag with the old prefix. PS: would only rename the class if they are in the same namespace else keep the old name
There was a problem hiding this comment.
@alexander-schranz i reverted some of the changes and added a tag to the deprecated visitors again.
94f1148 to
005bb01
Compare
What's in this PR?
Why?
Example Usage
To Do