Skip to content

Skip ContentRouteProvider in Sulu Page 3.0 #7855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

Prokyonn
Copy link
Member

@Prokyonn Prokyonn commented Mar 24, 2025

Q A
Bug fix? no yes
New feature? no yes
BC breaks? no yes
Deprecations? no yes
Fixed tickets fixes #
Related issues/PRs #
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

  • Skip contentRouteProvider when the new SuluPageBundle is registered

@@ -24,6 +24,7 @@
<argument type="service" id="sulu_core.webspace.request_analyzer"/>
<argument>null</argument><!-- not longer required -->
<argument type="collection" />
<argument type="service" id="service_container"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would check the bundle in the compiler pass and remove the whole service?

@alexander-schranz alexander-schranz added the DX Affecting the end developer label Mar 25, 2025
@alexander-schranz alexander-schranz merged commit 96eb166 into sulu:3.0 Mar 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants