Add navigation context to SuluPageBundle 3.0 #7839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/page/config/doctrine/Page/PageDimensionContent.orm.xml
Outdated
Show resolved
Hide resolved
packages/page/config/doctrine/Page/PageDimensionContent.orm.xml
Outdated
Show resolved
Hide resolved
alexander-schranz
requested changes
Mar 7, 2025
packages/page/config/doctrine/Page/PageDimensionContentNavigationContext.orm.xml
Outdated
Show resolved
Hide resolved
packages/page/config/doctrine/Page/PageDimensionContentNavigationContext.orm.xml
Outdated
Show resolved
Hide resolved
| <property | ||
| name="navigationContexts" | ||
| type="page_settings_navigation_select" | ||
| colspan="6" |
There was a problem hiding this comment.
Colspan looks strange as we don't know what the field after it is. Should we wrap this into a section Page Settings? 🤔
There was a problem hiding this comment.
Wrapped it into a section, but I still would like to use the colspan 6 to be consistent with the other settings like e.g. webspace
There was a problem hiding this comment.
Thinking about this... webspace should not even be there for pages 😂 we should tackle this in another PR
There was a problem hiding this comment.
Yeah remove the interface and trait from pages :)
packages/page/config/forms/content_settings_navigation_context.xml
Outdated
Show resolved
Hide resolved
28d8ab5 to
bd77949
Compare
Co-authored-by: Alexander Schranz <alexander@sulu.io>
bd77949 to
4628bf4
Compare
4628bf4 to
1d1d53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds NavigationContexts to pages in the new SuluPageBundle 3.0