Add test for route update for cross site changes #7834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f350216 to
a0a52c0
Compare
17 tasks
a0a52c0 to
6f33912
Compare
| @@ -53,6 +53,7 @@ public function testUpdateRoute( | |||
| array $routes, | |||
| string $changeRoute, | |||
| array $expectedRoutes, | |||
| int $expectedChangedRoutes, | |||
There was a problem hiding this comment.
Introduced a bug which skipped the expectedHistoryRoutes part. with additional assertCount this can now not longer happen.
| $this->assertSame('page::' . $expectedHistoryRoute['resourceId'], $route->getResourceId(), $additionalErrorInfoMessage); | ||
| } | ||
| $this->assertCount($expectedChangedRoutes, $expectedHistoryRoutes); | ||
| foreach ($expectedHistoryRoutes as $expectedHistoryRoute) { |
There was a problem hiding this comment.
no changes here removed unnecessary if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add test for route update for cross site updates.
Why?
If I have an article which are not site specific and it is connected to a page.