Add global blocks to Sulu 3.0 #7826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6dec5a6 to
cd13ce5
Compare
cd13ce5 to
7459b57
Compare
| $contentViews = []; | ||
| foreach ($data as $key => $block) { | ||
| if (!\is_array($block) || !isset($block['type']) || !\is_string($block['type'])) { | ||
| continue; | ||
| } | ||
|
|
||
| $type = $block['type']; | ||
| $formMetadata = $metadataTypes[$type] ?? null; | ||
| $formMetadata = $globalBlocksMetadata[$type] ?? $metadataTypes[$type] ?? null; |
There was a problem hiding this comment.
we prefer always the global block here now but what if a local block type was defined without a ref to a global block?
alexander-schranz
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds global blocks support for the new content structure for Sulu 3.0