Add more details to exception messages in FormatManager #7825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Prokyonn As discussed. 🙂 |
Prokyonn
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Thank you, looks good 👍
@michaelzangerle can you please change the target branch to 2.5 and rebase it
0bf3377 to
a2efd27
Compare
|
@Prokyonn Done 🙂 |
Prokyonn
approved these changes
Mar 5, 2025
|
Looks like the tests unexpectly is outputting something the cli directly now Think |
Merged
|
@alexander-schranz Should be fixed in here #7837 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Improves the exception messages.
Why?
Generic exception messages are not helpful when debugging bugs. Examples before and after:
Media was not found=>Media with id "%s" was not found.Requested FileVersion for media was not found=>Requested FileVersion "%s" for media with id "%s" was not found.