Replace Sulu 3.0 packages PHPUnit Annotations with Attributes #7819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
commented
Feb 24, 2025
| */ | ||
| #[\PHPUnit\Framework\Attributes\CoversNothing] |
There was a problem hiding this comment.
Technically this does cover the controller, just not everything else.
| @@ -44,6 +46,7 @@ | |||
| // SymfonySetList::SYMFONY_CODE_QUALITY, | |||
| // DoctrineSetList::DOCTRINE_CODE_QUALITY, | |||
| // LevelSetList::UP_TO_PHP_80, | |||
| PHPUnitSetList::ANNOTATIONS_TO_ATTRIBUTES, | |||
There was a problem hiding this comment.
is PHPUnit 10 used on 2.6? then we probably should enable this also there?
alexander-schranz
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adding a rector rule that enforces the use of Attributes over Annotations.
Also adding the "packages" directory to the rector files.
Why?
Since the introduction of PhpUnit 10 we can use Attributes for everything. They're better supported by PHP than annotations.
Example Usage
See changes.