Skip to content

Tabula rasa 🗑️ tests of Page, Snippet, DocumentManager and CustomUrl #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2025
Merged

Tabula rasa 🗑️ tests of Page, Snippet, DocumentManager and CustomUrl #7807

merged 5 commits into from
Feb 13, 2025

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Feb 13, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no (as only tests removed)
Fixed tickets fixes #
Related issues/PRs #7672
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Remove tests of Page, Snippet, DocumentManager and CustomUrl:

git rm -rf src/Sulu/Bundle/DocumentManager/Tests
git rm -rf src/Sulu/Bundle/CustomUrl/Tests
git rm -rf src/Sulu/Bundle/SnippetBundle/Tests
git rm -rf src/Sulu/Bundle/PageBundle/Tests
git rm src/Sulu/Bundle/SecurityBundle/Tests/Application/SecuredDocument.php
# remove secured document in: src/Sulu/Bundle/SecurityBundle/Tests/Application/config/config.yml
# remove phpcr based env in: src/Sulu/Bundle/SecurityBundle/Tests/Application/config/webspaces/sulu.io.xml
# remove phpcr based test in: src/Sulu/Bundle/SecurityBundle/Tests/Functional/Controller/PermissionControllerTest.php

Why?

All PHPCR based bundles will be rewritten from stretch in #7672 into packages/ dir.

To avoid that tests of code we will remove slow down the process we will remove such tests inside this bundles.

@alexander-schranz alexander-schranz force-pushed the feature/tabula-rasa-tests branch from c2c39c0 to 11697f3 Compare February 13, 2025 08:37
@alexander-schranz alexander-schranz added the DX Affecting the end developer label Feb 13, 2025
@alexander-schranz alexander-schranz force-pushed the feature/tabula-rasa-tests branch from ff51742 to ff5d109 Compare February 13, 2025 09:30
@Prokyonn Prokyonn merged commit cbe28c8 into sulu:3.0 Feb 13, 2025
8 of 9 checks passed
@alexander-schranz alexander-schranz deleted the feature/tabula-rasa-tests branch February 13, 2025 09:41
@alexander-schranz alexander-schranz added this to the Release 3.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prokyonn Prokyonn Prokyonn approved these changes

Assignees
No one assigned
Labels
DX Affecting the end developer
Projects
None yet
Milestone
Release 3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-schranz @Prokyonn