Skip to content

Remove old PHPCR based bundles from code base #7794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Feb 6, 2025

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #7672
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Remove old PHPCR based code:

Rerun this commands when rebasing:

# Move JS package
mkdir packages/snippet/assets
git mv src/Sulu/Bundle/SnippetBundle/Resources/js packages/snippet/assets/js
# update root package.json reference
# update snippet package.json reference to admin and website bundle
# update depcruise config include packages/*/assets/js

# Removing Snippet Bundle parts
git rm -rf src/Sulu/Bundle/SnippetBundle
git rm -rf src/Sulu/Component/Snippet
git rm src/Sulu/Bundle/PageBundle/Tests/Functional/Mapper/ContentMapperSnippetTest.php
# remove routing references to "@SuluSnippetBundle/Resources/config/routing_api.yml"
# update metadata check for snippet bundle

# more coming soon

Update config/bundles.php and src/Sulu/Bundle/TestBundle/Kernel/SuluTestKernel.php.
Update phpstan-baseline.php by remove above paths from it.

Why?

That @chirimoya has his cleanup branch to see what is failing when we remove PHPCR parts.

@alexander-schranz alexander-schranz changed the title Remove old PHPCR based snippet bundle from code base Remove old PHPCR based bundles from code base Feb 6, 2025
@alexander-schranz alexander-schranz added the DX Affecting the end developer label Feb 6, 2025
@alexander-schranz alexander-schranz added this to the Release 3.0 milestone Feb 6, 2025
@alexander-schranz alexander-schranz force-pushed the cleanup/3.0 branch 4 times, most recently from 7f70967 to e1aea35 Compare February 12, 2025 17:52
 Conflicts:
	src/Sulu/Bundle/PageBundle/Tests/Application/config/templates/pages/test_page.xml
	src/Sulu/Bundle/PageBundle/Tests/Application/config/templates/pages/with_snippet.xml
	src/Sulu/Bundle/PageBundle/Tests/Functional/Command/ContentTypesDumpCommandTest.php
@alexander-schranz
Copy link
Member Author

replaced by github.com//pull/7995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant