-
Notifications
You must be signed in to change notification settings - Fork 351
Remove old PHPCR based bundles from code base #7794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
086181c
to
ca36877
Compare
7f70967
to
e1aea35
Compare
e1aea35
to
e2d4017
Compare
Conflicts: src/Sulu/Bundle/PageBundle/Tests/Application/config/templates/pages/test_page.xml src/Sulu/Bundle/PageBundle/Tests/Application/config/templates/pages/with_snippet.xml src/Sulu/Bundle/PageBundle/Tests/Functional/Command/ContentTypesDumpCommandTest.php
e2d4017
to
42c8fa7
Compare
d2a842d
to
da7504f
Compare
replaced by github.com//pull/7995 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove old PHPCR based code:
Rerun this commands when rebasing:
Update
config/bundles.php
andsrc/Sulu/Bundle/TestBundle/Kernel/SuluTestKernel.php
.Update
phpstan-baseline.php
by remove above paths from it.Why?
That @chirimoya has his cleanup branch to see what is failing when we remove PHPCR parts.