Skip to content

Remove module property of permissions #7788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Feb 5, 2025

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets -
Related issues/PRs #7547
License MIT
Documentation PR -

What's in this PR?

Removing unused module field.

Why?

Less code = less bugs

@mamazu mamazu force-pushed the permissions_module branch 3 times, most recently from f25039e to e755f23 Compare February 5, 2025 17:08
@mamazu mamazu added Technical Debt Impacts code quality, no or just small impact on end developers and users DX Affecting the end developer labels Feb 5, 2025
@mamazu mamazu closed this Feb 5, 2025
@mamazu mamazu reopened this Feb 5, 2025
@mamazu mamazu force-pushed the permissions_module branch from 1cc88a4 to bae0336 Compare February 5, 2025 18:54
@alexander-schranz
Copy link
Member

@mamazu can you rebase and solve the conflict.

@mamazu mamazu force-pushed the permissions_module branch from ee1900f to f56e6c6 Compare March 13, 2025 13:13
@mamazu mamazu force-pushed the permissions_module branch from f56e6c6 to 0bb9a79 Compare March 13, 2025 13:15
@alexander-schranz alexander-schranz enabled auto-merge (squash) March 13, 2025 13:15
@alexander-schranz alexander-schranz merged commit 9a357a9 into sulu:3.0 Mar 13, 2025
9 checks passed
@mamazu mamazu deleted the permissions_module branch March 13, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants