Fix some new phpstan issues in new packages #7783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
reviewed
Feb 4, 2025
packages/article/src/Infrastructure/Sulu/Content/ArticleSelectionContentType.php
Show resolved
Hide resolved
| */ | ||
| private function setExcerptData(ExcerptInterface $dimensionContent, array $data): void | ||
| { | ||
| if (\array_key_exists('excerptTitle', $data)) { | ||
| Assert::nullOrString($data['excerptTitle']); |
There was a problem hiding this comment.
not sure about this "runtime" checks maybe we should go with assert instead which is compiled away on prod for better performance in cases used for imports.
| $dimensionContent->setSeoHideInSitemap($data['seoHideInSitemap'] ?? false); | ||
| $dimensionContent->setSeoNoFollow($data['seoNoFollow'] ?? false); | ||
| $dimensionContent->setSeoNoIndex($data['seoNoIndex'] ?? false); | ||
| if (\array_key_exists('seoTitle', $data)) { |
There was a problem hiding this comment.
this was missing. See excerpt as or other data mapper as reference only set data if send else stay untouched.
There was a problem hiding this comment.
moved to the TestBundle
|
@Prokyonn would be good if you could target the ContentResolver part in a PR: |
Prokyonn
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix some bew phpstan issues in new packages.
Why?
After upgrade to PHPStan 2.0 we got some new issues on the 3.0 branch we tackle them here before doing a baseline.