Remove MetaTwigExtension and SeoTwigExtension
#7782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UPGRADE.md
Outdated
| @@ -2,6 +2,12 @@ | |||
|
|
|||
| ## 3.0.0 | |||
|
|
|||
| ### Removing deprecated twig functions | |||
| - `sulu_meta_alternate` (use `sulu_seo` instead) | |||
There was a problem hiding this comment.
sulu_seo is deprecated:
sulu/src/Sulu/Bundle/WebsiteBundle/Twig/Seo/SeoTwigExtension.php
Lines 75 to 80 in 0c27c41
Replacement is calling directly the twig file like in the skeleton:
There was a problem hiding this comment.
Should I also include the removal of this function in this PR or create a different PR for that?
There was a problem hiding this comment.
You can remove it in this PR
e70199e to
7d290f9
Compare
MetaTwigExtensionMetaTwigExtension and SeoTwigExtension
alexander-schranz
approved these changes
Mar 10, 2025
|
Should be ready for merging now. |
alexander-schranz
approved these changes
Mar 13, 2025
|
@mamazu awesome. Thank you 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Removing the deprecated
MetaTwigExtensionWhy?
Sulu 3.0 cleanup is real.