Mark deprecated twig functions #7770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new TwigFilter( | ||
| 'sulu_util_domain_info', | ||
| [$this, 'extract'], | ||
| ['deprecation_info' => new DeprecatedCallableInfo(package: 'sulu/sulu', version: 2.3)], |
There was a problem hiding this comment.
not supported by our range of supported twig versions
There was a problem hiding this comment.
Then just deprecated => true?
There was a problem hiding this comment.
if that works for all our supported twig versions
There was a problem hiding this comment.
Yes, that behaviour works in the old versions and (deprecated) in the new versions.
5c80ab1 to
f09ac1b
Compare
f09ac1b to
ba640f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Marking twig functions as deprecated.
Why?
We want to let the user know what functions are going to be removed in the next version.