Skip to content

Remove deprecated SecurityType #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

Remove deprecated SecurityType #7759

merged 2 commits into from
Mar 13, 2025

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Jan 29, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? -
Fixed tickets -
Related issues/PRs #7547
License MIT
Documentation PR -

What's in this PR?

Removing the default fixture for Security Type entities.

Why?

We don't need to provide empty fixtures to the user. They can create fixtures on their own for the entities they want.

@mamazu mamazu force-pushed the security_type_fixtures branch from adb3e55 to cd4029b Compare January 29, 2025 10:33
@mamazu mamazu added Technical Debt Impacts code quality, no or just small impact on end developers and users DX Affecting the end developer labels Jan 29, 2025
@mamazu mamazu changed the title Removing deprecated security type fixtures Removing deprecated SecurityType fixtures Jan 29, 2025
@mamazu
Copy link
Contributor Author

mamazu commented Jan 29, 2025

We could also remove the feature completely as it is currently not used anymore in the core.

@alexander-schranz
Copy link
Member

alexander-schranz commented Jan 29, 2025 •
edited
Loading

The whole SecurityType model/entity and its repository can be removed.

@mamazu mamazu force-pushed the security_type_fixtures branch 2 times, most recently from 0203e72 to 1633e46 Compare January 29, 2025 16:16
@alexander-schranz
Copy link
Member

we should not forgot to add a UPGRADE.md with a example mysql SQL to remove the tables / columns.

@mamazu mamazu marked this pull request as draft January 29, 2025 16:23
@mamazu mamazu force-pushed the security_type_fixtures branch from 1633e46 to 8085d1d Compare January 29, 2025 16:33
@mamazu mamazu changed the title Removing deprecated SecurityType fixtures Removing deprecated SecurityType Jan 29, 2025
@mamazu mamazu force-pushed the security_type_fixtures branch 2 times, most recently from 3c6c267 to 98ffad2 Compare January 29, 2025 16:56
@mamazu mamazu marked this pull request as ready for review January 29, 2025 18:36
@mamazu mamazu force-pushed the security_type_fixtures branch 2 times, most recently from a0c9a09 to 876b877 Compare February 5, 2025 20:02
@mamazu mamazu force-pushed the security_type_fixtures branch from 876b877 to 2e126c6 Compare March 13, 2025 13:29
@mamazu mamazu force-pushed the security_type_fixtures branch from 2e126c6 to 7edb541 Compare March 13, 2025 13:36
@alexander-schranz alexander-schranz enabled auto-merge (squash) March 13, 2025 13:37
@alexander-schranz alexander-schranz changed the title Removing deprecated SecurityType Remove deprecated SecurityType Mar 13, 2025
auto-merge was automatically disabled March 13, 2025 13:42

Head branch was pushed to by a user without write access

@mamazu mamazu force-pushed the security_type_fixtures branch from 7edb541 to d4d7e87 Compare March 13, 2025 13:42
@mamazu
Copy link
Contributor Author

mamazu commented Mar 13, 2025

Now it should be ready

@alexander-schranz alexander-schranz merged commit 4a72394 into sulu:3.0 Mar 13, 2025
9 checks passed
@alexander-schranz
Copy link
Member

Awesome thank you!

@mamazu mamazu deleted the security_type_fixtures branch March 13, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees
No one assigned
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamazu @alexander-schranz