Skip to content

Remove deprecated memoize function #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Jan 28, 2025

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? -
Fixed tickets -
Related issues/PRs #7547
License MIT
Documentation PR -

What's in this PR?

Removing deprecated functions.

Why?

Cleaning up 3.0

@mamazu mamazu force-pushed the deprecation_memoize branch from 629b8a7 to a898359 Compare January 28, 2025 12:51
UPGRADE.md Outdated
@@ -119,7 +123,7 @@ services:
<details>
<summary>Sulu Google Cloud Config to Flysystem S3</summary>

> [!NOTE]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid unrelated moficationsin the UPGRADE.md file:

PS: space has special meaning in md files.
If the IDE supports it we configure in the editorconfig file to avoid this:

[*.md]
trim_trailing_whitespace = false

But still you can in most IDEs manually configure this per file extension via the UI.

UPGRADE.md Outdated
Comment on lines 51 to 54
Removed unused functions:
- `Sulu\Component\Cache\Memoize::memoize`
- `Sulu\Component\Cache\MemoizeInterface::memoize`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be moved to the Removed deprecated functions and properties: section

@mamazu mamazu force-pushed the deprecation_memoize branch 2 times, most recently from 419d907 to 1674858 Compare January 28, 2025 13:06
@mamazu
Copy link
Contributor Author

mamazu commented Jan 28, 2025

Done

@mamazu mamazu added the DX Affecting the end developer label Jan 28, 2025
@mamazu mamazu changed the title Removing deprecated memoize functions Remov deprecated memoize function Jan 28, 2025
@mamazu mamazu added the Technical Debt Impacts code quality, no or just small impact on end developers and users label Jan 28, 2025
@mamazu mamazu changed the title Remov deprecated memoize function Remove deprecated memoize function Jan 28, 2025
@mamazu mamazu force-pushed the deprecation_memoize branch from 1674858 to d166921 Compare January 29, 2025 16:07
@mamazu mamazu force-pushed the deprecation_memoize branch from d166921 to 1eb2fd8 Compare February 5, 2025 15:38
@mamazu mamazu force-pushed the deprecation_memoize branch from 1eb2fd8 to 40aed3c Compare February 5, 2025 16:30
@mamazu mamazu closed this Feb 5, 2025
@mamazu mamazu reopened this Feb 5, 2025
@mamazu mamazu changed the title Remove deprecated memoize function Remove deprecated memoize function Mar 13, 2025
@alexander-schranz alexander-schranz merged commit 414d47b into sulu:3.0 Mar 13, 2025
9 checks passed
@mamazu mamazu deleted the deprecation_memoize branch March 13, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants