-
Notifications
You must be signed in to change notification settings - Fork 351
Remove deprecated memoize
function
#7753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
629b8a7
to
a898359
Compare
UPGRADE.md
Outdated
@@ -119,7 +123,7 @@ services: | |||
<details> | |||
<summary>Sulu Google Cloud Config to Flysystem S3</summary> | |||
|
|||
> [!NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid unrelated moficationsin the UPGRADE.md file:
PS: space has special meaning in md files.
If the IDE supports it we configure in the editorconfig file to avoid this:
[*.md]
trim_trailing_whitespace = false
But still you can in most IDEs manually configure this per file extension via the UI.
UPGRADE.md
Outdated
Removed unused functions: | ||
- `Sulu\Component\Cache\Memoize::memoize` | ||
- `Sulu\Component\Cache\MemoizeInterface::memoize` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be moved to the Removed deprecated functions and properties:
section
419d907
to
1674858
Compare
Done |
1674858
to
d166921
Compare
d166921
to
1eb2fd8
Compare
1eb2fd8
to
40aed3c
Compare
memoize
function
What's in this PR?
Removing deprecated functions.
Why?
Cleaning up 3.0