Fix block response for minOccurs=1 / maxOccurs=1 #7751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
97
to
103
| $minOccurs = $metadata->getMinOccurs(); | ||
| $maxOccurs = $metadata->getMaxOccurs(); | ||
|
|
||
| if (1 === $minOccurs && 1 === $maxOccurs && \count($contentViews) > 0) { | ||
| $contentViews = $contentViews[0]->getContent(); | ||
| } | ||
|
|
There was a problem hiding this comment.
@benr77 can you test if this ends in the expected result?
| $maxOccurs = $metadata->getMaxOccurs(); | ||
|
|
||
| if (1 === $minOccurs && 1 === $maxOccurs && \count($contentViews) > 0) { | ||
| $contentViews = $contentViews[0]->getContent(); |
There was a problem hiding this comment.
@Prokyonn aren't we loosing the view now?
There was a problem hiding this comment.
You were right, fixed it.
alexander-schranz
approved these changes
Feb 4, 2025
1ab9c35 to
01569c4
Compare
|
Confirmed this is working as expected :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adjusts the response of the
BlockPropertyResolverto return the single block instead of a list whenminOccursandmaxOccursare1.Why?
The behaviour should not be changed between Sulu 2.6 and 3.0.