Skip to content

Remove deprecated UserGroup feature #7750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Jan 24, 2025

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets -
Related issues/PRs #7547
License MIT
Documentation PR -

What's in this PR?

Removing deprecated UserGroup and Group entities, associated controller, tests and orm files.

Why?

This feature has been marked deprecated and announced removal in 3.0. So we don't want to disappoint people.

@mamazu
Copy link
Contributor Author

mamazu commented Jan 24, 2025

I've changed the doctrine mappings. Do I also have to generate a migration for that or is that left up to the projects using Sulu?

@mamazu mamazu force-pushed the remove-user-groups branch 4 times, most recently from c7f7909 to d4a3a1f Compare January 24, 2025 15:20
@alexander-schranz
Copy link
Member

@mamazu we document it in the UPGRADE.md as mysql example.

@mamazu mamazu added DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users labels Jan 28, 2025
@mamazu mamazu changed the title Remove deprecated user groups feature Remove deprecated UserGroup feature Jan 29, 2025
@mamazu mamazu force-pushed the remove-user-groups branch 2 times, most recently from 4b8233f to 44517dc Compare February 5, 2025 15:39
@mamazu mamazu force-pushed the remove-user-groups branch from 44517dc to 2c6068d Compare February 5, 2025 17:28
@mamazu mamazu closed this Feb 5, 2025
@mamazu mamazu reopened this Feb 5, 2025
@mamazu mamazu force-pushed the remove-user-groups branch from aa76876 to 2dcdc4b Compare March 13, 2025 14:02
@alexander-schranz alexander-schranz merged commit 54c27ea into sulu:3.0 Mar 13, 2025
9 checks passed
@alexander-schranz
Copy link
Member

@mamazu thank you!

@mamazu mamazu deleted the remove-user-groups branch March 13, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants