Removed remaining Symfony 5.4 BC layer #7743
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15e0bd7 to
8b2c6a2
Compare
mamazu
commented
Jan 20, 2025
| use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | ||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
|
|
||
| class AliasForSecurityEncoderCompilerPass implements CompilerPassInterface |
There was a problem hiding this comment.
Technically the class is not deprecated, but the contents of the method is. Should I still remove it?
| @@ -39,6 +39,7 @@ | |||
| </parameters> | |||
|
|
|||
| <services> | |||
| <service id="sulu_security.encoder_factory" alias="security.password_hasher_factory" /> | |||
There was a problem hiding this comment.
We could remove the sulu_security.encoder_factory and replace it with security.password_hasher_factory as the bc layer between encoder and hasher is not longer required.
There was a problem hiding this comment.
And type it now as PasswordHasherFactoryInterface:
instead of the phpdoc967f4ae to
97deaca
Compare
|
This also means the entire functionality around the Salt can be removed. As the modern Symfony algorithms don't use that. |
55b9140 to
e2008e7
Compare
|
@alexander-schranz The UserManager changes seem to cause problems in the tests but in the dev container the service exists. |
|
lets revert that and keep the |
e2008e7 to
978e770
Compare
|
Done |
978e770 to
d556401
Compare
27 tasks
9485163 to
34c6715
Compare
db1b28d to
7c6ed9a
Compare
7c6ed9a to
2c342bb
Compare
2c342bb to
767eb71
Compare
c66af5b to
11a0dfa
Compare
1dd29e6 to
12f87f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Removing old configurations of Symfony 5.4 since we don't support the version anyways.
Why?
In Sulu 3 the minimum version is 6.4.
Less things we need to port and maintain.