Skip to content

Remove deprecated $entityKeys on controllers #7742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Jan 19, 2025

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets -
Related issues/PRs #7547
License MIT
Documentation PR -

What's in this PR?

Replacing the $entityKey properties with the RESOURCE_KEY property of the entities.

Why?

Less code to maintain

@mamazu mamazu added the DX Affecting the end developer label Jan 20, 2025
@alexander-schranz alexander-schranz merged commit 5c03699 into sulu:3.0 Jan 20, 2025
8 of 9 checks passed
@alexander-schranz
Copy link
Member

@mamazu Thank you!

@mamazu mamazu deleted the deprecations_resourcekeys branch January 20, 2025 18:05
mamazu added a commit to mamazu/sulu that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants