Replace ListRepresentation with PaginatedRepresentation #7740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9267567 to
4185ec7
Compare
4185ec7 to
e47c20e
Compare
alexander-schranz
approved these changes
Jan 19, 2025
|
@mamazu the 3.0 phpstan Lint can currently be ignored. There are a few things we need discuss internal which I don't wanted directly be added to the baseline. |
|
Okay then I'll close the other PR. Do you have a tip for how to deal with this locally? Because with removing classes I like to remove the class and then just fix the places where phpstan complains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Replacing the deprecated
ListRepresentationwith thePaginatedRepresentation.Why?
It's deprecated so let's remove it.