Fix issue with trailing slash in Matomo analytics templates #7737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +1 @@ | |||
| <noscript><p><img referrerpolicy="no-referrer-when-downgrade" src="{{ analytics.content.url }}/matomo.php?idsite={{ analytics.content.siteId }}&rec=1" style="border:0;" alt="" /></p></noscript> | |||
| <noscript><p><img referrerpolicy="no-referrer-when-downgrade" src="{{ analytics.content.url|trim('/') }}/matomo.php?idsite={{ analytics.content.siteId }}&rec=1" style="border:0;" alt="" /></p></noscript> | |||
There was a problem hiding this comment.
why its more technical we should only rtrim url here only, technical URLs are allowed to start with // which are "Protocol-relative URLs":
Suggested change
| <noscript><p><img referrerpolicy="no-referrer-when-downgrade" src="{{ analytics.content.url|trim('/') }}/matomo.php?idsite={{ analytics.content.siteId }}&rec=1" style="border:0;" alt="" /></p></noscript> | |
| <noscript><p><img referrerpolicy="no-referrer-when-downgrade" src="{{ analytics.content.url|trim('/', 'right') }}/matomo.php?idsite={{ analytics.content.siteId }}&rec=1" style="border:0;" alt="" /></p></noscript> |
There was a problem hiding this comment.
Sounds good to me. Changed the commit and updated the PR.
0c118c4 to
3a6d0e4
Compare
alexander-schranz
approved these changes
Jan 17, 2025
|
@fnagel thank you! |
|
I've updated my 3.0 branch and this is now working perfectly. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixed for missing trailing slashes.
Why?
In order to fix Matomo URLs.
Context
Follow-up to 84a6d7b