Use tagged_iterator for Initalizer services
#7724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e80757 to
d05ef4f
Compare
tagged_iterator for Initalizer services
tagged_iterator for Initalizer servicestagged_iterator for Initalizer services
16 tasks
50eb672 to
e876a65
Compare
e876a65 to
83c9721
Compare
|
@Prokyonn Is this still relevant or can this PR be closed? |
no I don't think this is relevant for Sulu 3.0, as the DocumentManagerBundle will be removed anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Replacing the
InitializerPasswith a tagged iterator.BC Breaks:
Why?
All of what the
InitializerPasscan do the tagged iterator can do as well.