Skip to content

Using tagged_iterator instead of deprecated tagged #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 3.0
Choose a base branch
from

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Jan 8, 2025

Q A
Bug fix? no
New feature? no
BC breaks? no (Only applications below Symfony 4.4)
Deprecations? Removing ones
Fixed tickets -
Related issues/PRs -
License MIT
Documentation PR -

What's in this PR?

Replacing the service type tagged with the tagged_iterator.

Why?

Less deprecations from Symfony:

Since symfony/dependency-injection 7.2: Type "tagged" is deprecated for tag <argument>, use "tagged_iterator" instead in "/home/mamazu/packages/sulu/sulu/packages/content/config/services.xml".

In Symfony the tagged type was introduced in 4.4 and Symfony converted to the new type in 5.0.

@mamazu mamazu changed the base branch from 2.6 to 3.0 January 8, 2025 14:47
@mamazu mamazu added Technical Debt Impacts code quality, no or just small impact on end developers and users DX Affecting the end developer labels Jan 8, 2025
@mamazu mamazu force-pushed the using-tagged_iterator branch from 21d3841 to da63740 Compare January 9, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant