Skip to content

Conversation

draconivis
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #3118
Related issues/PRs #3118
License MIT
Documentation PR

What's in this PR?

Removes the HTTP 1.0 Headers Expires & Pragma

Why?

As suggested in #3118

@draconivis draconivis self-assigned this Jan 8, 2025
@alexander-schranz
Copy link
Member

@draconivis can you target the 3.0 branch for this and rebase it to 3.0.

# replace "origin" with the remote name targeting "sulu/sulu": `git remote -v`
# if remote does not exist add it via: `git remote add sulu git@github.com:sulu/sulu.git`

git fetch origin
git rebase -i origin/3.0

# force push required after rebase a branch:
git push <your_remote> improvement/remove-http-headers --force

Also add a line to the UPGRADE.md about removing this 2 headers.

@draconivis draconivis force-pushed the improvement/remove-http-headers branch from 1755b19 to 0b427ed Compare January 8, 2025 12:24
@draconivis draconivis changed the base branch from 2.6 to 3.0 January 8, 2025 12:28
@alexander-schranz alexander-schranz changed the title remove Expires & Pragma HTTP headers Remove Expires & Pragma HTTP headers of Media Format response Jan 8, 2025
@alexander-schranz alexander-schranz added the Technical Debt Impacts code quality, no or just small impact on end developers and users label Jan 8, 2025
@alexander-schranz
Copy link
Member

alexander-schranz commented Jan 8, 2025

@draconivis can we add a check for the cache-control headers and for the removed headers Pragma and Expires to:

Copy link
Member

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust one functional test to check for the response headers

@draconivis draconivis force-pushed the improvement/remove-http-headers branch from 3daba68 to 4001ccf Compare January 9, 2025 07:00
@alexander-schranz alexander-schranz enabled auto-merge (squash) January 9, 2025 12:47
@alexander-schranz alexander-schranz merged commit de334ab into sulu:3.0 Jan 9, 2025
9 checks passed
@alexander-schranz
Copy link
Member

@draconivis Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Removing HTTP 1.0 headers
2 participants