Replace Uuid->__toString() with more descriptive Uuid->toRfc4122 #7704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
approved these changes
Jan 9, 2025
0388672 to
68d6973
Compare
|
@RafaelKr can you try to repush something. The CI seems not be triggered not sure if the fork is corrupt or something else going wrong. |
68d6973 to
0388672
Compare
0388672 to
cd30bf3
Compare
|
@alexander-schranz I just rebased on 3.0 and force-pushed Edit: It says "This workflow requires approval from a maintainer." |
|
Looks like the "new github merge experience" is missing that button had to disable the new merge UI now I did see the button again. Thx for letting us know @RafaelKr . |
|
@mamazu we may should add a |
|
@RafaelKr thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Use
Uuid::v7()->toRfc4122()instead ofUuid::v7()->__toString().Why?
Both methods output the
$this->uidproperty, buttoRfc4122also describes the returned format (e.g.f81d4fae-7dec-11d0-a765-00a0c91e6bf6)