Remove guzzle dependency from LocationBundle
#7694
Conversation
d11d1fc to
3977825
Compare
composer.json
Outdated
| @@ -50,7 +50,6 @@ | |||
| "friendsofsymfony/jsrouting-bundle": "^3.0", | |||
| "friendsofsymfony/rest-bundle": "^3.2", | |||
| "gedmo/doctrine-extensions": "^3.8", | |||
| "guzzlehttp/promises": "^1.0 || ^2.0", | |||
There was a problem hiding this comment.
the promises package need to stay will not be removed they are required that the http cache working performant with the symfony http client:
There was a problem hiding this comment.
Interesting. Very weird that this is not a dependency of either of those packages. Because we don't use any of the classes in the Sulu source code.
Readded.
There was a problem hiding this comment.
@mamazu you can use any php http implementation with the FosHttpCache component.
As Symfony based we choose the Symfony Http Client it provides the async:
But its async implementation depends on guzzle promises (documented here) which is not a direct dependency as you can use it without async still.
We may can discuss with @dbu if the FOSHttpCacheBundle as it is a symfony bundle may could require it as I think its uncommon that somebody using another client inside a symfony project?
There was a problem hiding this comment.
Yeah I think that would make sense. But that's probably a topic for another pull request.
There was a problem hiding this comment.
FOSHttpCache uses php-http/discovery which contains a composer plugin that requires a suiteable http client if none is already available in your project.
e8a8e9c to
bcdb82a
Compare
UPGRADE.md
Outdated
| @@ -28,6 +28,10 @@ Removed unused arguments: | |||
|
|
|||
| The script provided by Sulu for the piwik implementation has been updated to use mataomo path so the script is now pointing to matomo.php instead of the piwik.php file. | |||
|
|
|||
| ### Removing deprecated guzzle integration | |||
|
|
|||
| As part of the update of flysystem the package `guzzlehttp/guzzle` and `guzzlehttp/promise` have been removed. If you need it you need to manually require it. | |||
There was a problem hiding this comment.
The GoogleGeolocator and NominatimGeolocator not longer supporting the Guzzle Http Client instead a Symfony HttpClient instance need to give to its constructors now.
bcdb82a to
5371975
Compare
What's in this PR?
Removing the guzzle dependency from the project.
Why?
Currently we still have a dependency on the guzzle http implementation for BC reasons. This merge request removes the option to use the guzzle http client in the
LocationBundle.The reason is that the guzzle http client isn't even a depnency of Sulu and only installed because of the old flysystem dependency. See #7687 (comment)