Replace piwik with matomo analytic templates #7693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fnagel thx for the pull request can you add a short line to the Something similar to: |
Based on Matomo version 5.1.2. See sulu#7692
5b44b6f to
138da56
Compare
|
@alexander-schranz Changed the |
alexander-schranz
approved these changes
Nov 28, 2024
|
@fnagel awesome. Thank you! |
benr77
reviewed
Jan 15, 2025
| _paq.push(['trackPageView']); | ||
| _paq.push(['enableLinkTracking']); | ||
| (function() { | ||
| var u="{{ analytics.content.url|trim('/') }}"; | ||
| _paq.push(['setTrackerUrl', u+'/piwik.php']); | ||
| _paq.push(['setTrackerUrl', u+'matomo.php']); |
There was a problem hiding this comment.
The forward slash has been removed here, which is causing invalid URLs to be constructed.
There was a problem hiding this comment.
You are right. I copied the latest code from the Matomo docs without checking what the u variable will contain. Thanks!
benr77
reviewed
Jan 15, 2025
| @@ -1 +1 @@ | |||
| <noscript><p><img src="{{ analytics.content.url }}/piwik.php?idsite={{ analytics.content.siteId }}" style="border:0;" alt="" /></p></noscript> | |||
| <noscript><p><img referrerpolicy="no-referrer-when-downgrade" src="{{ analytics.content.url }}/matomo.php?idsite={{ analytics.content.siteId }}&rec=1" style="border:0;" alt="" /></p></noscript> | |||
There was a problem hiding this comment.
This also needs the |trim('/') filter to ensure there is not a duplicate forward slash.
There was a problem hiding this comment.
You're right. This seems to be an issue even before my changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Updated the Matomo templates.
Why?
Because the current ones are outdated.