Move Sulu Content Bundle namespace and integrate the content bundle into test setup #7675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,6 +109,7 @@ | |||
| "symfony/translation-contracts": "^2.5 || ^3.0", | |||
| "symfony/twig-bundle": "^6.4 || ^7.1", | |||
| "symfony/validator": "^6.4 || ^7.1", | |||
| "symfony/workflow": "^6.4 || ^7.1", | |||
There was a problem hiding this comment.
new requirement
| @@ -152,7 +147,7 @@ | |||
| "scheb/2fa-google-authenticator": "^6.10 || ^7.0", | |||
| "scheb/2fa-totp": "^6.10 || ^7.0", | |||
| "scheb/2fa-trusted-device": "^6.0 || ^7.0", | |||
| "sulu/content-bundle": "dev-feature/content-resolver as 0.9.0", | |||
| "sulu/automation-bundle": "^3.0@dev", | |||
There was a problem hiding this comment.
content bundle has tests based on automation bundle which we need to check
0ab4629 to
291f6ba
Compare
e78eeac to
60aaa7a
Compare
9958fbc to
bd44d61
Compare
Comment on lines
+223
to
+227
| $entityFieldQuery = self::CONTENT_RICH_ENTITY_ALIAS . '.' . $this->getEntityIdField(); | ||
| if ($this->entityManager->getConnection()->getDatabasePlatform() instanceof PostgreSQLPlatform) { | ||
| // TODO no casting because indexes can then not be used | ||
| $entityFieldQuery = 'CAST(' . self::CONTENT_RICH_ENTITY_ALIAS . '.' . $this->getEntityIdField() . ' AS STRING)'; | ||
| } |
There was a problem hiding this comment.
this is a temp hack to support PostgreSQL at current state we should remove this kind of general services to make things easier in future handled directly in the bundles they belong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Move Sulu Content Bundle namespace and integrate the content bundle into test setup.
Why?
We moved ContentBundle in #7674 to the mono repository. Now some refactoring is required to move it into the correct namespace.
BC Breaks
Sulu\Bundle\ContentBundle\Content->Sulu\ContentSulu\Bundle\ContentBundle\SuluContentBundle->Sulu\Content\Infrastructure\Symfony\HttpKernel\SuluContentBundle