Add sulu/sulu replaces sulu/article-bundle to composer fix phpstan issues in smart content #7659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4ae199 to
b3eb9ac
Compare
Comment on lines
+101
to
+104
| $result[] = new ArrayAccessItem($article->getId(), [ | ||
| 'id' => $article->getId(), | ||
| 'title' => $dimensionContent->getTitle(), | ||
| ]; | ||
| ], $article); |
There was a problem hiding this comment.
hopefully we will remove this classes soon but currently phpstan requires ResourceItemInterface. hope this breaks nothing for your case.
Comment on lines
+191
to
+193
| /** @var int[] $tags */ // TODO check whats correct here sulu defines string, content bundle int | ||
| $tags = $filters['tags']; | ||
| $filter['tagIds'] = $tags; |
There was a problem hiding this comment.
need to check this cast whats correct here. may content and sulu is handling tags here differently and so differently typed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add sulu/sulu replaces sulu/article-bundle to composer.
Why?
The article bundle was merged into sulu/sulu #7653 .