Skip to content

Remove deprecated ListingRestHelpers #7620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Oct 20, 2024

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets -
Related issues/PRs -
License MIT
Documentation PR -

What's in this PR?

Removing the already deprecated ListingRestHelper.

Why?

Less code to maintain and it has a lot of type issues

@mamazu mamazu force-pushed the deprecated_listing_rest_helper branch from fda24ec to 65fae3a Compare October 20, 2024 15:33
@mamazu mamazu added Technical Debt Impacts code quality, no or just small impact on end developers and users DX Affecting the end developer labels Oct 28, 2024
@mamazu mamazu force-pushed the deprecated_listing_rest_helper branch from 65fae3a to a53ab40 Compare October 28, 2024 17:43
@alexander-schranz alexander-schranz merged commit 7e3d025 into sulu:3.0 Nov 26, 2024
7 of 8 checks passed
@alexander-schranz
Copy link
Member

@mamazu Thank you!

@mamazu mamazu deleted the deprecated_listing_rest_helper branch November 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants